Re: ✘Time for 3.22?

[Fred Wright]

On Wed, 16 Dec 2020, Gary E. Miller wrote:
> On Tue, 15 Dec 2020 21:16:24 -0800 (PST)
> Fred Wright <fw@fwright.net> wrote:
>
> > On Tue, 15 Dec 2020, Gary E. Miller wrote:
> >
> > > > Thanks.  A few more days is fine.
> > >
> > > Any progress testing git head?
> >
> > I've only managed to do basic build/check testing so far, though
> > across all the platforms I normally test.  The one problem so far is
> > that some platforms don't have a sufficiently recent SCons to include
> > the CheckProg() function.
>
> Ugh.  Any platforms we care about?  What version scons does not have it?

CentOS 7, Ubuntu 14, Debian 7, and OpenBSD 5.6 all have the issue.

On Wed, 16 Dec 2020, Gary E. Miller wrote:
> On Tue, 15 Dec 2020 21:16:24 -0800 (PST)
> Fred Wright <fw@fwright.net> wrote:
>
> > > I've only managed to do basic build/check testing so far, though
> > > across all the platforms I normally test.  The one problem so far is
> > > that some platforms don't have a sufficiently recent SCons to
> > > include the CheckProg() function.
>
> Looks like CheckProg has been in gpsd for a while.  Here are many of
> them:
>
> SConscript:    have_tar = config.CheckProg(env['TAR'])
> SConscript:        have_coverage = config.CheckProg('coverage')
> SConscript:        have_cppcheck = config.CheckProg('cppcheck')
> SConscript:        have_dia = config.CheckProg('dia')
> SConscript:        have_flake8 = config.CheckProg('flake8')
> SConscript:        have_pycodestyle = config.CheckProg('pycodestyle')
> SConscript:        have_pylint = config.CheckProg('pylint')
> SConscript:        have_scan_build = config.CheckProg('scan-build')
> SConscript:        have_valgrind = config.CheckProg('valgrind')
> SConscript:        have_xmllint = config.CheckProg('xmllint')
>
> The way CheckProg has been used so far is to fail nicely when CheckProg
> is missing.  I just added that to the TAR check.  Pushed to git head.
> The effect is that you will not be able to make a release if you do not
> have CheckProg.

That seems reasonable.  It doesn't need to support building releases on as 
wide a range of platforms as it does building and running.  Though it's a 
plus that it no longer needs Gnu tar.

I'd added something using CheckProg() at one point, but included a 
fallback.  That was for the macOS install_name issue, which is now handled 
differently, so that CheckProg() is long gone.

More testing to come.

Fred Wright