gpsd-dev
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: mtk3301_speed_switcher - Merge Request


From: Gary E. Miller
Subject: Re: mtk3301_speed_switcher - Merge Request
Date: Mon, 13 Sep 2021 17:02:18 -0700

Yo Jared!

On Mon, 13 Sep 2021 22:49:24 +0000
Jared Hagel <jared.hagel@vontas.com> wrote:

> We have a requirement to change the baud rate of our MTK3301 GPS
> receiver, so I was hoping to have the attached change merged into
> GPSD. I've tested this on our hardware and it works fine for us. Let
> me know what you think.

Thanks, applied, with a few style changes.  The big one was this:

    for (int i = 0; ...

Some compilers do not like that.

Otherwise:
    gpsd snuggles braces up with if and for
    line lengths under 80 chars
    single line comments start with //

RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
        gem@rellim.com  Tel:+1 541 382 8588

            Veritas liberabit vos. -- Quid est veritas?
    "If you can't measure it, you can't improve it." - Lord Kelvin

Attachment: pgpgPmPKhAVgf.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]