[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Quectel FW version - Merge Request
From: |
Gary E. Miller |
Subject: |
Re: Quectel FW version - Merge Request |
Date: |
Fri, 4 Mar 2022 14:45:41 -0800 |
Yo Jared!
On Fri, 4 Mar 2022 22:30:01 +0000
Jared Hagel <jared.hagel@vontas.com> wrote:
> We have a requirement to retrieve the Quectel FW version of our
> Quectel (MTK3301) GPS receiver, so I was hoping to have the attached
> change merged into GPSD. I've tested this on our hardware and it
> works fine for us. Let me know what you think.
Good start, but is not secure code. I'll take a look at it.
Also some formatting problems, like the lines longer than 80 columns.
Can you provide a raw data capture that include the PQVERNO message?
Can you make this am Merge Request to make it easier to review.
RGDS
GARY
---------------------------------------------------------------------------
Gary E. Miller Rellim 109 NW Wilmington Ave., Suite E, Bend, OR 97703
gem@rellim.com Tel:+1 541 382 8588
Veritas liberabit vos. -- Quid est veritas?
"If you can't measure it, you can't improve it." - Lord Kelvin
pgp0UT_uRX3JX.pgp
Description: OpenPGP digital signature
- Quectel FW version - Merge Request, Jared Hagel, 2022/03/04
- Re: Quectel FW version - Merge Request,
Gary E. Miller <=
- RE: Quectel FW version - Merge Request, Jared Hagel, 2022/03/04
- Re: Quectel FW version - Merge Request, Gary E. Miller, 2022/03/04
- RE: Quectel FW version - Merge Request, Jared Hagel, 2022/03/07
- Re: Quectel FW version - Merge Request, Gary E. Miller, 2022/03/07
- Re: Quectel FW version - Merge Request, Gary E. Miller, 2022/03/07
- RE: Quectel FW version - Merge Request, Jared Hagel, 2022/03/08
- RE: Quectel FW version - Merge Request, Jared Hagel, 2022/03/09
- Re: Quectel FW version - Merge Request, Gary E. Miller, 2022/03/09
- RE: Quectel FW version - Merge Request, Jared Hagel, 2022/03/10
- Re: Quectel FW version - Merge Request, Gary E. Miller, 2022/03/10