groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 01/01: [hdtbl] Don't clean other people's unit tests.


From: G. Branden Robinson
Subject: [groff] 01/01: [hdtbl] Don't clean other people's unit tests.
Date: Tue, 13 Nov 2018 23:55:27 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 09080df0f8895c07f55f36f4835bab0f44dcaa7c
Author: G. Branden Robinson <address@hidden>
Date:   Tue Nov 13 23:21:14 2018 -0500

    [hdtbl] Don't clean other people's unit tests.
    
        * contrib/hdtbl/hdtbl.am: test-hdtbl.sh is generated from an .in
        file, so while we can add it to $(TESTS), we shouldn't then add
        $(TESTS) to $(MOSTLYCLEANFILES) or we will clobber all tests
        that ever get defined.  This affected gdiffmk's test script on
        in-tree builds.  Introduce new variable, $(hdtbl_TESTS).  Now
        it clobbers no more.
    
        Fixes <https://savannah.gnu.org/bugs/index.php?55020>.
    
    Signed-off-by: G. Branden Robinson <address@hidden>
---
 ChangeLog              | 13 +++++++++++++
 contrib/hdtbl/hdtbl.am |  5 +++--
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 71a6609..81bbff2 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2018-11-13  G. Branden Robinson <address@hidden>
+
+       [hdtbl] Don't clean other people's unit tests.
+
+       * contrib/hdtbl/hdtbl.am: test-hdtbl.sh is generated from an .in
+       file, so while we can add it to $(TESTS), we shouldn't then add
+       $(TESTS) to $(MOSTLYCLEANFILES) or we will clobber all tests
+       that ever get defined.  This clobbered gdiffmk's test script on
+       in-tree builds.  Give it its own variable, $(hdtbl_TESTS).  Now
+       it clobbers no more.
+
+       Fixes <https://savannah.gnu.org/bugs/index.php?55020>.
+
 2018-11-12  G. Branden Robinson <address@hidden>
 
        * m4/groff.m4 (GROFF_PAGE): Try /etc/papersize first.
diff --git a/contrib/hdtbl/hdtbl.am b/contrib/hdtbl/hdtbl.am
index 2a47096..18b23e3 100644
--- a/contrib/hdtbl/hdtbl.am
+++ b/contrib/hdtbl/hdtbl.am
@@ -102,7 +102,8 @@ EXTRA_DIST += \
   contrib/hdtbl/hdtbl.tmac-u \
   contrib/hdtbl/hdmisc.tmac-u
 
-TESTS += contrib/hdtbl/examples/test-hdtbl.sh
+hdtbl_TESTS = contrib/hdtbl/examples/test-hdtbl.sh
+TESTS += $(hdtbl_TESTS)
 contrib/hdtbl/examples/test-hdtbl.sh: $(top_builddir)/config.status \
        $(HDTBLPROCESSEDEXAMPLEFILES) 
$(top_srcdir)/contrib/hdtbl/examples/test-hdtbl.sh.in
        sed -e "s|address@hidden@]|$(abs_top_builddir)|g" \
@@ -110,7 +111,7 @@ contrib/hdtbl/examples/test-hdtbl.sh: 
$(top_builddir)/config.status \
                $(top_srcdir)/contrib/hdtbl/examples/test-hdtbl.sh.in > $@
        chmod +x $@
 
-MOSTLYCLEANFILES += $(TESTS)
+MOSTLYCLEANFILES += $(hdtbl_TESTS)
 
 # Rule to generate ps and roff files
 SUFFIXES += .roff .in .ps



reply via email to

[Prev in Thread] Current Thread [Next in Thread]