[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[groff] 02/02: tbl: Make diagnostic less misleading.
From: |
G. Branden Robinson |
Subject: |
[groff] 02/02: tbl: Make diagnostic less misleading. |
Date: |
Sat, 10 Oct 2020 05:32:49 -0400 (EDT) |
gbranden pushed a commit to branch master
in repository groff.
commit 59ea3d2dbfaaccc2f39c73eb826a2eca50db75cb
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Oct 10 20:17:42 2020 +1100
tbl: Make diagnostic less misleading.
* src/preproc/tbl/table.cpp (table::init_output): In the release macro
written to the output, reword the warning diagnostic that is emitted
when a table row is to be output without enough room before the next
page location trap. The former wording said that a "text block" would
not fit on the page, and that is normally how table rows grow longer
than one line in the first place. However, there are other ways the
conditional can be satisfied, as witnessed in Savannah #57665, so
simply say what is known; that the table _row_ overruns the space to
the next trap (we say the row won't "fit on [the] page").
Fixes <https://savannah.gnu.org/bugs/index.php?59233>.
---
ChangeLog | 15 +++++++++++++++
src/preproc/tbl/table.cpp | 2 +-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/ChangeLog b/ChangeLog
index f15e87b..7f01f62 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,20 @@
2020-10-10 G. Branden Robinson <g.branden.robinson@gmail.com>
+ * src/preproc/tbl/table.cpp (table::init_output): In the release
+ macro written to the output, reword the warning diagnostic that
+ is emitted when a table row is to be output without enough room
+ before the next page location trap. The former wording said
+ that a "text block" would not fit on the page, and that is
+ normally how table rows grow longer than one line in the first
+ place. However, there are other ways the conditional can be
+ satisfied, as witnessed in Savannah #57665, so simply say what
+ is known; that the table _row_ overruns the space to the next
+ trap (we say the row won't "fit on [the] page").
+
+ Fixes <https://savannah.gnu.org/bugs/index.php?59233>.
+
+2020-10-10 G. Branden Robinson <g.branden.robinson@gmail.com>
+
* src/preproc/tbl/table.cpp
(double_line_entry::double_line_entry):
(double_line_entry::simple_print): Remove garbage lines
diff --git a/src/preproc/tbl/table.cpp b/src/preproc/tbl/table.cpp
index 534e00c..dd8fcac 100644
--- a/src/preproc/tbl/table.cpp
+++ b/src/preproc/tbl/table.cpp
@@ -1857,7 +1857,7 @@ void table::init_output()
loop when we try and print it; it will just go off the
bottom of the page. */
". tmc \\n[.F]: around line \\n[.c]: warning:\n"
- ". tm1 \" table text block will not fit on page \\n%\n"
+ ". tm1 \" table row will not fit on page \\n%\n"
".\\}\n"
".nf\n"
".if \\n[ln] .nm \\n[ln]\n"
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- [groff] 02/02: tbl: Make diagnostic less misleading.,
G. Branden Robinson <=