groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 11/14: [grohtml]: Add assertion.


From: G. Branden Robinson
Subject: [groff] 11/14: [grohtml]: Add assertion.
Date: Mon, 1 Nov 2021 09:19:40 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit da9ea393899990bdc0861e4a40eff684c9989343
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Mon Nov 1 12:48:32 2021 +1100

    [grohtml]: Add assertion.
    
    * src/devices/grohtml/post-html.cpp (html_printer::do_file_components):
      Add assertion.
    
    The command "echo | ./build/test-groff -Thtml" was core dumping on me.
    `current_paragraph` was a null pointer.  groff 1.22.4 was fine.  A
    bisect did not track down the problem, and it no longer manifested after
    return to Git HEAD and rebuilding.  I presume there is a missing
    dependency somewhere that skipped necessary rebuilding/relinking.  Until
    that can be tracked down, explicitly slam on the brakes if the situation
    arises again.
---
 ChangeLog                         | 5 +++++
 src/devices/grohtml/post-html.cpp | 1 +
 2 files changed, 6 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 51ad9f0..c548606 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2021-11-01  G. Branden Robinson <g.branden.robinson@gmail.com>
 
+       * src/devices/grohtml/post-html.cpp
+       (html_printer::do_file_components): Add assertion.
+
+2021-11-01  G. Branden Robinson <g.branden.robinson@gmail.com>
+
        * src/devices/grops/ps.cpp (usage): Document -p and --version
        options.
 
diff --git a/src/devices/grohtml/post-html.cpp 
b/src/devices/grohtml/post-html.cpp
index 5758280..e716217 100644
--- a/src/devices/grohtml/post-html.cpp
+++ b/src/devices/grohtml/post-html.cpp
@@ -5042,6 +5042,7 @@ void html_printer::do_file_components (void)
   if (fragment_no > 1)
     write_navigation(top, prev, next, current);
   else {
+    assert(current_paragraph != 0);
     current_paragraph->done_para();
     write_rule();
     if (valid_flag) {



reply via email to

[Prev in Thread] Current Thread [Next in Thread]