groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 03/09: [libgroff]: Slightly refactor.


From: G. Branden Robinson
Subject: [groff] 03/09: [libgroff]: Slightly refactor.
Date: Tue, 23 Nov 2021 09:04:45 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit 45bf156fd82783e1c0eae36816e6ac0fc21446bd
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sun Nov 21 13:05:34 2021 +1100

    [libgroff]: Slightly refactor.
    
    * src/include/error.h: Drop `extern` storage class from diagnostic
      function prototypes.
    
    Also update editor aid comments; drop old style Emacs file-local
    variable setting.
---
 ChangeLog           |  5 ++++
 src/include/error.h | 79 ++++++++++++++++++++++++++++-------------------------
 2 files changed, 47 insertions(+), 37 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 2a43f7f..a3887e7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,10 @@
 2021-11-20  G. Branden Robinson <g.branden.robinson@gmail.com>
 
+       * src/include/error.h: Drop `extern` storage class from
+       diagnostic function prototypes.
+
+2021-11-20  G. Branden Robinson <g.branden.robinson@gmail.com>
+
        * src/libs/libgroff/font.cpp (font::load): Update diagnostic
        messages to say "kerning pair" instead of "kern pair".
 
diff --git a/src/include/error.h b/src/include/error.h
index 6784c51..359b4d1 100644
--- a/src/include/error.h
+++ b/src/include/error.h
@@ -1,4 +1,3 @@
-// -*- C++ -*-
 /* Copyright (C) 1989-2020 Free Software Foundation, Inc.
      Written by James Clark (jjc@jclark.com)
 
@@ -17,52 +16,58 @@ for more details.
 You should have received a copy of the GNU General Public License
 along with this program.  If not, see <http://www.gnu.org/licenses/>. */
 
-extern void fatal_with_file_and_line(const char *filename, int lineno,
-                                    const char *format,
-                                    const errarg &arg1 = empty_errarg,
-                                    const errarg &arg2 = empty_errarg,
-                                    const errarg &arg3 = empty_errarg);
+void fatal_with_file_and_line(const char *filename, int lineno,
+                             const char *format,
+                             const errarg &arg1 = empty_errarg,
+                             const errarg &arg2 = empty_errarg,
+                             const errarg &arg3 = empty_errarg);
 
-extern void error_with_file_and_line(const char *filename, int lineno,
-                                    const char *format,
-                                    const errarg &arg1 = empty_errarg,
-                                    const errarg &arg2 = empty_errarg,
-                                    const errarg &arg3 = empty_errarg);
+void error_with_file_and_line(const char *filename, int lineno,
+                             const char *format,
+                             const errarg &arg1 = empty_errarg,
+                             const errarg &arg2 = empty_errarg,
+                             const errarg &arg3 = empty_errarg);
 
-extern void warning_with_file_and_line(const char *filename, int lineno,
-                                    const char *format,
-                                    const errarg &arg1 = empty_errarg,
-                                    const errarg &arg2 = empty_errarg,
-                                    const errarg &arg3 = empty_errarg);
+void warning_with_file_and_line(const char *filename, int lineno,
+                               const char *format,
+                               const errarg &arg1 = empty_errarg,
+                               const errarg &arg2 = empty_errarg,
+                               const errarg &arg3 = empty_errarg);
 
-extern void debug_with_file_and_line(const char *filename, int lineno,
-                                    const char *format,
-                                    const errarg &arg1 = empty_errarg,
-                                    const errarg &arg2 = empty_errarg,
-                                    const errarg &arg3 = empty_errarg);
+void debug_with_file_and_line(const char *filename, int lineno,
+                             const char *format,
+                             const errarg &arg1 = empty_errarg,
+                             const errarg &arg2 = empty_errarg,
+                             const errarg &arg3 = empty_errarg);
 
-extern void fatal(const char *,
-                 const errarg &arg1 = empty_errarg,
-                 const errarg &arg2 = empty_errarg,
-                 const errarg &arg3 = empty_errarg);
+void fatal(const char *,
+          const errarg &arg1 = empty_errarg,
+          const errarg &arg2 = empty_errarg,
+          const errarg &arg3 = empty_errarg);
 
-extern void error(const char *,
-                 const errarg &arg1 = empty_errarg,
-                 const errarg &arg2 = empty_errarg,
-                 const errarg &arg3 = empty_errarg);
+void error(const char *,
+          const errarg &arg1 = empty_errarg,
+          const errarg &arg2 = empty_errarg,
+          const errarg &arg3 = empty_errarg);
 
-extern void warning(const char *,
-                   const errarg &arg1 = empty_errarg,
-                   const errarg &arg2 = empty_errarg,
-                   const errarg &arg3 = empty_errarg);
+void warning(const char *,
+            const errarg &arg1 = empty_errarg,
+            const errarg &arg2 = empty_errarg,
+            const errarg &arg3 = empty_errarg);
 
-extern void debug(const char *,
-                 const errarg &arg1 = empty_errarg,
-                 const errarg &arg2 = empty_errarg,
-                 const errarg &arg3 = empty_errarg);
+void debug(const char *,
+          const errarg &arg1 = empty_errarg,
+          const errarg &arg2 = empty_errarg,
+          const errarg &arg3 = empty_errarg);
 
 
 extern "C" const char *program_name;
 extern int current_lineno;
 extern const char *current_filename;
 extern const char *current_source_filename;
+
+// Local Variables:
+// fill-column: 72
+// mode: C++
+// End:
+// vim: set cindent noexpandtab shiftwidth=2 textwidth=72:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]