groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 31/45: [me]: Fix bad unit test.


From: G. Branden Robinson
Subject: [groff] 31/45: [me]: Fix bad unit test.
Date: Thu, 20 Jan 2022 10:17:53 -0500 (EST)

gbranden pushed a commit to branch master
in repository groff.

commit a58b4cb5ba7344f9734677231039ee5bb19e9b36
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Wed Jan 19 18:51:39 2022 +1100

    [me]: Fix bad unit test.
    
    * tmac/tests/e_chapter-titles-work.sh: Fix missing shell test at end of
      script, which caused it to exit successfully regardless of any test
      failures.  Irritating.  This is among the fruits of the "never, ever
      use 'set -e'" tree.  (This religion has a thick bible:
      https://mywiki.wooledge.org/BashFAQ/105>.)  Fortunately, all the tests
      pass legitimately.
---
 ChangeLog                           | 11 +++++++++++
 tmac/tests/e_chapter-titles-work.sh |  2 ++
 2 files changed, 13 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 9646ab27..a8af115f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,14 @@
+2022-01-19  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [me]: Fix bad unit test.
+
+       * tmac/tests/e_chapter-titles-work.sh: Fix missing shell test at
+       end of script, which caused it to exit successfully regardless
+       of any test failures.  Irritating.  This is among the fruits of
+       the "never, ever use 'set -e'" tree.  (This religion has a thick
+       bible: https://mywiki.wooledge.org/BashFAQ/105>.)  Fortunately,
+       all the tests pass legitimately.
+
 2022-01-16  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [font]: For 'ascii' and 'latin1' devices, consistently define
diff --git a/tmac/tests/e_chapter-titles-work.sh 
b/tmac/tests/e_chapter-titles-work.sh
index 61e38407..94979687 100755
--- a/tmac/tests/e_chapter-titles-work.sh
+++ b/tmac/tests/e_chapter-titles-work.sh
@@ -63,4 +63,6 @@ echo "$output" | grep -Fq "Chapter 2" || wail
 echo "checking formatted appendix heading output" >&2
 echo "$output" | grep -Fq "Appendix A" || wail
 
+test -z "$fail"
+
 # vim:set ai et sw=4 ts=4 tw=72:



reply via email to

[Prev in Thread] Current Thread [Next in Thread]