groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 23/23: [tbl]: Fix Savannah #49390.


From: G. Branden Robinson
Subject: [groff] 23/23: [tbl]: Fix Savannah #49390.
Date: Sat, 30 Jul 2022 14:53:46 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit 8818c07cff782fc8a0fec7597cd789bd1a02a20b
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Sat Jul 30 11:04:22 2022 -0500

    [tbl]: Fix Savannah #49390.
    
    * src/preproc/tbl/table.cpp (table::do_bottom): Avoid overprinting a
      boxed table's bottom border on nroff devices.
    
    Fixes <https://savannah.gnu.org/bugs/?49390>.  Thanks to Osamu Sayama
    for the report.
---
 ChangeLog                 | 10 ++++++++++
 src/preproc/tbl/table.cpp |  5 +++++
 2 files changed, 15 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 4407d8f88..53f6e5248 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2022-07-30  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [tbl]: Fix Savannah #49390.
+
+       * src/preproc/tbl/table.cpp (table::do_bottom): Avoid
+       overprinting a boxed table's bottom border on nroff devices.
+
+       Fixes <https://savannah.gnu.org/bugs/?49390>.  Thanks to Osamu
+       Sayama for the report.
+
 2022-07-30  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [tbl]: Regression-test Savannah #49390.
diff --git a/src/preproc/tbl/table.cpp b/src/preproc/tbl/table.cpp
index 18cee1e92..dcf77b05d 100644
--- a/src/preproc/tbl/table.cpp
+++ b/src/preproc/tbl/table.cpp
@@ -3025,6 +3025,11 @@ void table::do_bottom()
           ".\\}\n");
   if (flags & DOUBLEBOX)
     prints(".sp " DOUBLE_LINE_SEP "\n");
+  // Horizontal box lines take up an entire row on nroff devices (maybe
+  // a half-row if we ever support [emulators of] devices like the
+  // Teletype Model 37 with half-line motions).
+  if (flags & (BOX | DOUBLEBOX | ALLBOX))
+    prints(".if n .sp\n");
   prints("." RESET_MACRO_NAME "\n"
         ".fc\n"
         ".cp \\n(" COMPATIBLE_REG "\n");



reply via email to

[Prev in Thread] Current Thread [Next in Thread]