groff-commit
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[groff] 07/32: [troff]: Fix Savannah #63151.


From: G. Branden Robinson
Subject: [groff] 07/32: [troff]: Fix Savannah #63151.
Date: Thu, 6 Oct 2022 09:11:21 -0400 (EDT)

gbranden pushed a commit to branch master
in repository groff.

commit 122f288e0b307c7caaac215a8cf18a96587ba6b3
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
AuthorDate: Tue Oct 4 00:27:15 2022 -0500

    [troff]: Fix Savannah #63151.
    
    * src/roff/troff/input.cpp (read_draw_node): Throw "delim" warning
      diagnostic when a drawing escape sequence ends the line without a
      closing delimiter.
    
    Fixes <https://savannah.gnu.org/bugs/?63151>.
---
 ChangeLog                | 10 ++++++++++
 src/roff/troff/input.cpp |  6 ++++++
 2 files changed, 16 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 0e1fcb87f..50e9e4c21 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2022-10-04  G. Branden Robinson <g.branden.robinson@gmail.com>
+
+       [troff]: Fix Savannah #63151.
+
+       * src/roff/troff/input.cpp (read_draw_node): Throw "delim"
+       warning diagnostic when a drawing escape sequence ends the line
+       without a closing delimiter.
+
+       Fixes <https://savannah.gnu.org/bugs/?63151>.
+
 2022-10-03  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        * tmac/fallbacks.tmac: Define fallbacks for characters in ISO
diff --git a/src/roff/troff/input.cpp b/src/roff/troff/input.cpp
index 0005cdaad..fcf6b26c7 100644
--- a/src/roff/troff/input.cpp
+++ b/src/roff/troff/input.cpp
@@ -8590,6 +8590,12 @@ static node *read_draw_node()
          maxpoints *= 2;
          delete[] oldpoint;
        }
+       if (tok.is_newline() || tok.is_eof()) {
+         warning(WARN_DELIM, "missing closing delimiter in drawing"
+                 " escape sequence (got %1)", tok.description());
+         err = true;
+         break;
+       }
        if (!get_hunits(&point[i].h,
                        type == 'f' || type == 't' ? 'u' : 'm')) {
          err = true;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]