[groff] 01/01: [gropdf]: Using \*[PDFLB] does not work.

[Deri James]

deri pushed a commit to branch master
in repository groff.

commit 99d76f5befb0d8d9276eba3483eea4ef2a2f1ec9
Author: Deri James <deri@chuzzlewit.myzen.co.uk>
AuthorDate: Sat Nov 30 17:14:31 2024 +0000

    [gropdf]: Using \*[PDFLB] does not work.
    
    * tmac/pdf.tmac: Simplify string and fix misconception
    about PDFNOTE.WIDTH and PDFNOTE.HEIGHT.
    
    Fixes <https://savannah.gnu.org/bugs/index.php?66501>
---
 ChangeLog     |  9 +++++++++
 tmac/pdf.tmac | 12 ++++++++----
 2 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index ae4477754..6e40af9ff 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2024-11-30  Deri James  <deri@chuzzlewit.myzen.co.uk>
+
+       [gropdf]: Using \*[PDFLB] does not work.
+
+       * tmac/pdf.tmac: Simplify string and fix misconception
+       about PDFNOTE.WIDTH and PDFNOTE.HEIGHT.
+
+       Fixes <https://savannah.gnu.org/bugs/index.php?66501>
+
 2024-11-30  G. Branden Robinson <g.branden.robinson@gmail.com>
 
        [lookbib]: Align with modern groff conventions.
diff --git a/tmac/pdf.tmac b/tmac/pdf.tmac
index 114985e92..234852c5a 100644
--- a/tmac/pdf.tmac
+++ b/tmac/pdf.tmac
@@ -118,8 +118,12 @@ am solely responsible for any bugs I may have introduced 
into this file.
 .\" them correctly!  Anyway, let's set some suitable default values,
 .\" in case the user has a set up which does work as advertised.
 .\"
-.nr PDFNOTE.WIDTH  3.5i
-.nr PDFNOTE.HEIGHT 2.0i
+.\" [Deri] These dimensions are the size of the hotspot area containing
+.\" the popup icon, not the size of the window containing the popup
+.\" text, so ...
+.\"
+.nr PDFNOTE.WIDTH  1c
+.nr PDFNOTE.HEIGHT 1c
 .\"
 .\" "pdf:bbox" defines the expression used to set the size and location
 .\" of the bounding rectangle for display of notes and link "hot-spots".
@@ -138,7 +142,7 @@ am solely responsible for any bugs I may have introduced 
into this file.
 .\"
 .\"    .pdfnote  Some text.\*[PDFLB]Some more text, on a new line.
 .\"
-.ds PDFLB \\\\\\\\\\\\\\\\n
+.ds PDFLB \\012
 .\"
 .de pdfnote
 .\" ----------------------------------------------------------------------
@@ -151,7 +155,7 @@ am solely responsible for any bugs I may have introduced 
into this file.
 .\"
 .   mk pdf:ury
 .   nr pdf:llx \\n(.k+\\n(.o+\\n[.in]
-.   nr pdf:lly \\n[pdf:ury]-\\n[PDFNOTE.HEIGHT]
+.   nr pdf:lly \\n[pdf:ury]+\\n[PDFNOTE.HEIGHT]
 .   nr pdf:urx \\n[pdf:llx]+\\n[PDFNOTE.WIDTH]
 .   ds pdf:note.instance /Rect [\\*[pdf:bbox]]
 .\"