Re: [Groff] macro `st' not defined

[Keith Marshall]

On Monday 16 January 2006 9:24 pm, Werner LEMBERG wrote:
> > Of course, since the resulting warning message is harmless, there
> > probably isn't any great urgency for this, but if you like, I will
> > have a look at what may be required.
>
> Please do so.

I've prepared a simple patch;  shall I commit it?

2006-01-??  Keith Marshall 

        Suppress `.st' request emission by `grn'.

        * src/preproc/grn/main.cpp (USE_ST_REQUEST): New macro.
        (conv): Use it.

Index: src/preproc/grn/main.cpp
===================================================================
RCS file: /cvsroot/groff/groff/src/preproc/grn/main.cpp,v
retrieving revision 1.4
diff -u -r1.4 main.cpp
--- src/preproc/grn/main.cpp    3 May 2005 10:05:33 -0000       1.4
+++ src/preproc/grn/main.cpp    24 Jan 2006 21:55:12 -0000
@@ -97,6 +97,20 @@

 /* #define DEFSTIPPLE    "gs" */
 #define DEFSTIPPLE     "cf"
+/*
+ * This grn implementation emits `.st' requests to control stipple effects,
+ * but groff does not (currently) support any such request.
+ *
+ * This hack disables the emission of such requests, without destroying the
+ * infrastructure necessary to support the feature in the future; to enable
+ * the emission of `.st' requests, at a future date when groff can support
+ * them, simply rewrite the following #define as:
+ *
+ *   #define USE_ST_REQUEST  stipple
+ *
+ * with accompanying comment: ``emit `.st' requests as required''.
+ */
+#define USE_ST_REQUEST  0      /* never emit `.st' requests */

 #define MAXINLINE      100     /* input line length */

@@ -566,7 +580,7 @@
             ".sp -1\n",
             xright - xleft, ybottom - ytop, GScommand);

-      if (stipple)             /* stipple requested for this picture */
+      if (USE_ST_REQUEST)      /* stipple requested for this picture */
        printf(".st %s\n", stipple);
       lastx = xleft;           /* note where we are (upper left */
       lastyline = lasty = ytop;        /* corner of the picture)        */
@@ -632,7 +646,7 @@
       printf("\\D't %du'\n", DEFTHICK);
       if (flyback)             /* make sure we end up at top of */
        printf(".sp -1\n");     /* picture if `flying back'      */
-      if (stipple)             /* restore stipple to previous */
+      if (USE_ST_REQUEST)      /* restore stipple to previous */
        printf(".st\n");
       printf(".br\n"
             ".ft \\n(g3\n"


Regards,
Keith.