Re: [Groff] [Groff-commit] groff ChangeLog Makefile.in aclocal.m4 configur...

[Werner LEMBERG]

Bernd,


there are some problems with this patch.

> address@hidden@
>  address@hidden@
> address@hidden@

We don't need PERL *and* PERLPATH.  You should rename everything to
use either the former or the latter.

> --- aclocal.m4        28 Dec 2012 11:59:30 -0000      1.58
> +++ aclocal.m4        14 Apr 2013 23:11:07 -0000      1.59
> @@ -1,7 +1,8 @@
> -# generated automatically by aclocal 1.12.5 -*- Autoconf -*-
> -
> -# Copyright (C) 1996-2012 Free Software Foundation, Inc.
> +# generated automatically by aclocal 1.11.6 -*- Autoconf -*-

Ouch.  Please always use the newest version aclocal and friends.  BTW,
this is one of the reasons to *not* include generated files in the
CVS...

> +# ===========================================================================
> +#    http://www.gnu.org/software/autoconf-archive/ax_compare_version.html
> +# ===========================================================================
> [...]

This is wrong.  You have apparently installed somewhere on your system
the macro file which contains AX_COMPARE_VERSION, but this makes the
call of autoreconf work *only* on your private computer.  Instead, you
have to add the file `ax_compare_version.m4' to groff's `m4'
directory!  If you do that, `aclocal.m4' will contain just a single
line, namely

 m4_include([m4/ax_compare_version.m4])

> +# We need Perl 5.6.1 or newer.
> +
> +AC_DEFUN([GROFF_PERL],
> +     [PERLVERSION=v5.6.1
> +     AC_PATH_PROG([PERL], [perl], [no])
> +     if test "$PERL" = "no"; then
> +       AC_MSG_ERROR([perl binary not found], 1)
> +     fi
> +        AX_PROG_PERL_VERSION([$PERLVERSION], PERLPATH=$PERL, \
> +          AC_MSG_ERROR([perl version is too old], 1))])

Please use tabs and spaces in a similar way as in the original files.
Here, the last two lines use spaces instead of tabs.  Additionally,
the first indentation level in `groff.m4' has two (or three) spaces,
not a tab, so it should be

AC_DEFUN([GROFF_PERL],
  [PERLVERSION=v5.6.1
   AC_PATH_PROG([PERL], [perl], [no])
   if test "x$PERL" = "xno"; then
     AC_MSG_ERROR([perl binary not found])
   fi
   AX_PROG_PERL_VERSION([$PERLVERSION],
     PERLPATH=$PERL,
     AC_MSG_ERROR([perl version is too old]))])

Note the use of `x' in the comparison since using

  "$PERL" = "no"

is not portable across existing shells in case $PERL expands to
nothing (this was a mistake in my example code, sorry).  Additionally,
you don't need a trailing `\' within m4 macros.


    Werner

_______________________________________________
Groff-commit mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/groff-commit