Re: [Groff] [patch] unbreak make install

[Ingo Schwarze]

Hi,

Bernd Warken wrote on Sun, Jun 22, 2014 at 12:24:56PM +0200:
> Ingo Schwarze wrote:

>> 2014-06-21  Ingo Schwarze  <address@hidden>
>> 
>>      * Makefile.in: Unbreak make install:
>>      Add missing gideal dirs to the dist tarball.
>> 
>> commit ec7cf4a2b06b21431fe576cc96960b1b5f1d2309
>> Author: Ingo Schwarze <address@hidden>
>> Date:   Sat Jun 21 23:06:17 2014 +0200
>> 
>>     unbreak make install: add missing gideal dirs to the dist tarball
>> 
>> diff --git a/Makefile.in b/Makefile.in
>> index dd927c7..8e6aed7 100644
>> --- a/Makefile.in
>> +++ b/Makefile.in
>> @@ -714,6 +714,8 @@ NOMAKEDIRS=\
>>    arch/djgpp \
>>    contrib/chem/examples \
>>    contrib/chem/examples/122 \
>> +  contrib/gideal/files \
>> +  contrib/gideal/libfiles \
>>    contrib/groffer/perl \
>>    contrib/groffer/shell \
>>    contrib/hdtbl/examples \

> Patch applied.  Thanx

That's not true.  You did *not* apply my patch.
Instead, you committed something else:

> commit 910b4557c92623ab5a47f225efbbabb87a40b898
> Author: Bernd Warken <address@hidden>
> Date:   Sun Jun 22 12:23:21 2014 +0200
> 
>     Makefile.in: add 2 directories from contrib/gideal: files and libfiles
> ---
>  ChangeLog   |    5 +++++
>  Makefile.in |    2 ++
>  2 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/ChangeLog b/ChangeLog
> index ee22bc1..8ab5db8 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,8 @@
> +2014-06-22  Bernd Warken  <address@hidden>
> +
> +     * Makefile.in: Add 2 directories of `contrib/gideal': `files' and
> +     'libfiles`.
> +
>  2014-06-19  Bernd Warken  <address@hidden>
>  
>       * src/roff/groff/groff.man: Correct the collection of the
> diff --git a/Makefile.in b/Makefile.in
> index dd927c7..33a30fd 100644
> --- a/Makefile.in
> +++ b/Makefile.in
> @@ -676,6 +676,8 @@ OTHERDIRS=\
>    contrib/eqn2graph \
>    contrib/gdiffmk \
>    contrib/gideal \
> +  contrib/gideal/files \
> +  contrib/gideal/libfiles \
>    contrib/glilypond \
>    contrib/gperl \
>    contrib/grap2graph \

Now the breakage is worse than it was before.

Before, "make dist" succeeded, then "make install" from inside
the generated tarball failed.

Now, it's already "make dist" that fails:

  address@hidden $ make distclean
  [...]
  address@hidden $ ./configure
  [...]
  address@hidden $ make dist
  [...]
  test -z "" || mv y_tab.h 
  make: cannot open ./Makefile.sub.
  *** Error 2 in tmp (Makefile:879 'contrib/gideal/files')
  *** Error 1 in tmp (Makefile:777 'distfiles')
  *** Error 1 in /co/groff (Makefile:899 'dist')

You can't add a directory to OTHERDIRS if it doesn't have a make
infrastructure.  You have to add it to NOMAKEDIRS.

Please revert your patch and push mine.

Thanks,
  Ingo