Re: [groff] 1.22.4.rc4 - Final RC before official 1.22.4

[Ingo Schwarze]

Hi Bertrand,

i finally figured out the hdtbl failure on Solaris.
The mom test is still failing, though.

OK to push the patch below, before release?
I see no regression on OpenBSD, and no regression on Debian.

Yours,
  Ingo


commit 9cb6801d5f90a221be6f22df975ef54a00751fef
Author: Ingo Schwarze <address@hidden>
Date:   Thu Dec 6 18:21:21 2018 +0100

    Improve shell script portability in the hdtbl fonts examples.
    
    1. POSIX requires "echo -n" to print "-n" followed by
       a newline character, so use printf(1) instead.
    2. According to POSIX, behaviour of tr(1) is undefined
       if string2 contains fewer characters than string1,
       and on Oracle Solaris, the excess characters in string1
       are not translated.  So make sure string2 contains
       a sufficient number of characters.

diff --git a/contrib/hdtbl/ChangeLog b/contrib/hdtbl/ChangeLog
index ecd7755d..86ede58b 100644
--- a/contrib/hdtbl/ChangeLog
+++ b/contrib/hdtbl/ChangeLog
@@ -1,3 +1,15 @@
+2018-12-06  Ingo Schwarze  <address@hidden>
+
+       * examples/fonts_n.in, examples/fonts_x.in:
+         Make the shell script in the .pso request more portable:
+         1. POSIX requires "echo -n" to print "-n" followed by
+            a newline character, so use printf(1) instead.
+         2. According to POSIX, behaviour of tr(1) is undefined
+            if string2 contains fewer characters than string1,
+            and on Oracle Solaris, the excess characters in string1
+            are not translated.  So make sure string2 contains
+            a sufficient number of characters.
+
 2018-08-09  Ingo Schwarze  <address@hidden>
 
        * examples/common.roff: Remove more dead code
diff --git a/contrib/hdtbl/examples/fonts_n.in 
b/contrib/hdtbl/examples/fonts_n.in
index 58f9acdb..72b5d2f3 100644
--- a/contrib/hdtbl/examples/fonts_n.in
+++ b/contrib/hdtbl/examples/fonts_n.in
@@ -52,9 +52,9 @@ along with this program.  If not, see 
<http://www.gnu.org/licenses/>.
 .    ds *args \\n[.fn]
 .
 .  pso sh -c \
-       "echo -n .ds *f\ ; \
+       "printf '%s' '.ds *f ' ; \
         ls \\*[fontpath]/dev\*[.T] \
-        | tr '[:cntrl:]' ' '"
+        | tr '[:cntrl:]' '[ *32]'"
 .  \"  This dummy line is necessary; the preceding line eats it.
 .
 .  while !"\\*[*args]"" \{\
diff --git a/contrib/hdtbl/examples/fonts_x.in 
b/contrib/hdtbl/examples/fonts_x.in
index f036f81d..a4f2eab0 100644
--- a/contrib/hdtbl/examples/fonts_x.in
+++ b/contrib/hdtbl/examples/fonts_x.in
@@ -52,9 +52,9 @@ along with this program.  If not, see 
<http://www.gnu.org/licenses/>.
 .    ds *args \\n[.fn]
 .
 .  pso sh -c \
-       "echo -n .ds *f\ ; \
+       "printf '%s' '.ds *f ' ; \
         ls \\*[fontpath]/dev\*[.T] \
-        | tr '[:cntrl:]' ' '"
+        | tr '[:cntrl:]' '[ *32]'"
 .  \"  This dummy line is necessary; the preceding line eats it.
 .
 .  while !"\\*[*args]"" \{\