buglet in mom 2.5d

[G. Branden Robinson]

Hi Peter,

There appears to be a nit in mom 2.5d.

When building, I got the following error:

troff:../contrib/mom/examples/typesetting.mom:316: error: empty escape name

It looks to me like everyone who builds groff with PDF support
configured will see this diagnostic.

I hacked the '-b' flag into mom's call of $(PDFMOMBIN) in mom.am to get
a backtrace.  (I recommend this going forward, after we "thaw" the
master branch.)  Here are the results.

$ make V=1 contrib/mom/examples/typesetting.pdf
 cd .. && /bin/bash /home/branden/src/GIT/groff/build-aux/missing automake-1.16 
--gnu Makefile
 cd . && /bin/bash ./config.status Makefile depfiles
config.status: creating Makefile
config.status: executing depfiles commands
/usr/bin/mkdir -p `dirname contrib/mom/examples/typesetting.pdf` \
&& LC_ALL=C GROFF_COMMAND_PREFIX= 
GROFF_BIN_PATH="/home/branden/src/GIT/groff/build" PDFMOM_BIN_PATH="." 
/home/branden/src/GIT/groff/build/pdfmom 
-F/home/branden/src/GIT/groff/build/font 
-F/home/branden/src/GIT/groff/build/../font 
-M/home/branden/src/GIT/groff/build/tmac 
-M/home/branden/src/GIT/groff/build/../tmac -M../contrib/mom -b -K utf8 -p -e 
-t ../contrib/mom/examples/typesetting.mom >contrib/mom/examples/typesetting.pdf
troff: backtrace: '../contrib/mom/om.tmac':1878: macro 'COLOR'
troff: backtrace: '../contrib/mom/om.tmac':3058: macro 'DBX'
troff: backtrace: file '../contrib/mom/examples/typesetting.mom':316
troff:../contrib/mom/examples/typesetting.mom:316: error: empty escape name
$ sed -n '1873,1883p' ../contrib/mom/om.tmac
.MAC COLOR END
.    ie \\n[.u]=1 \{\
\c
\\*[\\$1]\c
.    \}
.    el \\*[\\$1]
.END
\#
\# NEWCOLOR
\# --------
\# *Arguments:

It looks like `MAC` needs to be prepared for the possibility of being
passed no arguments...

$ sed -n '3053,3063p' ../contrib/mom/om.tmac
\D'P \\*[$BX_WIDTH] 0 0 \\*[$BX_DEPTH] -\\*[$BX_WIDTH] 0 0 -\\*[$BX_DEPTH]'
.       fcolor
.       rr #BX_SOLID
.    \}
.    el \{\
.       COLOR \\*[$BX_COLOR]
\Z'\D't \\n[#RULE_WEIGHT]''\
\h'\\*[$BX_INDENT]+\\n[#RULE_WEIGHT]u+\\n[#RULE_WEIGHT_ADJ]u'\
\v'\\n[#WEIGHT_ADJ]u'\
\D'p \\*[$BX_WIDTH]-\\n[#RULE_WEIGHT]u 0 0 \\*[$BX_DEPTH]-\\n[#RULE_WEIGHT]u 
-\\*[$BX_WIDTH]+\\n[#RULE_WEIGHT]u 0 0 -\\*[$BX_DEPTH]+\\n[#RULE_WEIGHT]u'\
\v'-\\n[#WEIGHT_ADJ]u'\

...or `DBX` needs to ensure that it doesn't call `COLOR` with an empty
string.

I hope this is a valid attempt at sleuthing.

Regards,
Branden

signature.asc
Description: PGP signature