[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] [troff]: Rewrite function in C.
From: |
Thorsten Glaser |
Subject: |
Re: [PATCH v1 2/2] [troff]: Rewrite function in C. |
Date: |
Fri, 4 Aug 2023 03:34:11 +0200 (CEST) |
On Fri, 4 Aug 2023, Alejandro Colomar wrote:
>* src/roff/troff/env.cpp (is_family_valid): The old code was
> eyeball-bleeding. This cuts 6 lines to 3, and each of them is
> significantly simpler to read. Remove the comments of how it could
> be improved using modern C++, as I don't think it would improve much
> vs this C implementation.
>
>Signed-off-by: Alejandro Colomar <alx@kernel.org>
lgtm: mirabilos <m@mirbsd.org>
bye,
//mirabilos
--
Stéphane, I actually don’t block Googlemail, they’re just too utterly
stupid to successfully deliver to me (or anyone else using Greylisting
and not whitelisting their ranges). Same for a few other providers such
as Hotmail. Some spammers (Yahoo) I do block.
- Re: [PATCH v1 2/2] [troff]: Rewrite function in C., (continued)
- Re: [PATCH v1 2/2] [troff]: Rewrite function in C., Alejandro Colomar, 2023/08/03
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., G. Branden Robinson, 2023/08/04
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., Alejandro Colomar, 2023/08/04
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., James K. Lowden, 2023/08/07
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., G. Branden Robinson, 2023/08/25
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., Alejandro Colomar, 2023/08/25
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., G. Branden Robinson, 2023/08/26
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., Lennart Jablonka, 2023/08/26
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., Alejandro Colomar, 2023/08/26
- Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., Alejandro Colomar, 2023/08/26
Re: [PATCH v1 2/2] [troff]: Rewrite function in C.,
Thorsten Glaser <=
Re: [PATCH v1 1/2] [troff]: Add lengthof() macro., Thorsten Glaser, 2023/08/04