[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 1/9] [libgroff]: Remove redundant checks.
From: |
Alejandro Colomar |
Subject: |
[PATCH v3 1/9] [libgroff]: Remove redundant checks. |
Date: |
Fri, 15 Mar 2024 15:24:14 +0100 |
ERANGE can only happen if strtol(3) returns either LONG_MIN or LONG_MAX.
Link: <https://savannah.gnu.org/bugs/?65451>
Cc: "G. Branden Robinson" <branden@debian.org>
Cc: Dave Kemper <saint.snit@gmail.com>
Cc: "James K. Lowden" <jklowden@schemamania.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---
src/libs/libgroff/curtime.cpp | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/libs/libgroff/curtime.cpp b/src/libs/libgroff/curtime.cpp
index 277755cab..490fc3018 100644
--- a/src/libs/libgroff/curtime.cpp
+++ b/src/libs/libgroff/curtime.cpp
@@ -42,8 +42,7 @@ struct tm *current_time()
char *endptr;
long epoch = strtol(source_date_epoch, &endptr, 10);
- if ((errno == ERANGE && (epoch == LONG_MAX || epoch == LONG_MIN)) ||
- (errno != 0 && epoch == 0))
+ if ((errno == ERANGE) || (errno != 0 && epoch == 0))
fatal("$SOURCE_DATE_EPOCH: strtol: %1", strerror(errno));
if (endptr == source_date_epoch)
fatal("$SOURCE_DATE_EPOCH: no digits found: '%1'", endptr);
--
2.43.0
signature.asc
Description: PGP signature
- [PATCH v5 02/10] [libgroff]: Remove dead code, (continued)
- [PATCH v5 02/10] [libgroff]: Remove dead code, Alejandro Colomar, 2024/03/16
- [PATCH v5 03/10] src/: Remove redundant checks after strtol(3)., Alejandro Colomar, 2024/03/16
- [PATCH v5 04/10] [grolbp]: Remove bogus (and redundant) check, Alejandro Colomar, 2024/03/16
- [PATCH v5 05/10] src/: ceil_prime(): Add function to get the lowest prime not less than n, Alejandro Colomar, 2024/03/16
- [PATCH v5 06/10] [indxbib]: Don't else after [[noreturn]], Alejandro Colomar, 2024/03/16
- [PATCH v5 07/10] [indxbib]: Clear errno before calling strtol(3), Alejandro Colomar, 2024/03/16
- [PATCH v5 08/10] [indxbib]: Remove dead code, Alejandro Colomar, 2024/03/16
- [PATCH v5 09/10] [indxbib]: Collapse related tests, Alejandro Colomar, 2024/03/16
- [PATCH v5 10/10] [grolbp]: Fix range check after strtol(3), Alejandro Colomar, 2024/03/16
- [PATCH v3 5/9] src/: ceil_prime(): Add function to get the lowest prime not smaller than n, Alejandro Colomar, 2024/03/15
- [PATCH v3 1/9] [libgroff]: Remove redundant checks.,
Alejandro Colomar <=
- [PATCH v3 7/9] [indxbib]: Clear errno before calling strtol(3), Alejandro Colomar, 2024/03/15
- [PATCH v3 8/9] [indxbib]: Remove dead code, Alejandro Colomar, 2024/03/15
- [PATCH v3 6/9] [indxbib]: Don't else after [[noreturn]], Alejandro Colomar, 2024/03/15
- [PATCH v3 9/9] [indxbib]: Collapse related tests, Alejandro Colomar, 2024/03/15