groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v4 04/10] [grolbp]: Remove bogus (and redundant) check


From: Alejandro Colomar
Subject: [PATCH v4 04/10] [grolbp]: Remove bogus (and redundant) check
Date: Sat, 16 Mar 2024 12:54:37 +0100

`str == end` can only happen if strtol(3) returns 0.

Closes: <https://savannah.gnu.org/bugs/?65451>
Cc: "G. Branden Robinson" <branden@debian.org>
Cc: Dave Kemper <saint.snit@gmail.com>
Cc: "James K. Lowden" <jklowden@schemamania.org>
Cc: Colin Watson <cjwatson@debian.org>
Cc: Werner LEMBERG <wl@gnu.org>
Signed-off-by: Alejandro Colomar <alx@kernel.org>
---
 src/devices/grolbp/lbp.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/devices/grolbp/lbp.cpp b/src/devices/grolbp/lbp.cpp
index 63077f16e..c05b42ec3 100644
--- a/src/devices/grolbp/lbp.cpp
+++ b/src/devices/grolbp/lbp.cpp
@@ -696,7 +696,7 @@ int main(int argc, char **argv)
       {
        char *ptr;
        long n = strtol(optarg, &ptr, 10);
-       if ((n <= 0) && (ptr == optarg))
+       if (ptr == optarg)
          error("argument for -c must be a positive integer");
        else if (n <= 0 || n > 32767)
          error("out of range argument for -c");
-- 
2.43.0

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]