Re: -Thtml double free in tcache 2; Abort

[G. Branden Robinson]

Hi Alex,

At 2024-06-16T22:49:38+0200, Alejandro Colomar wrote:
> > alx@debian:~/tmp/groff$ cat keyrings.7 
> > .TH a s d f
> > .SH foo
> > .TP
> > foobar
> > alx@debian:~/tmp/groff$ troff -man -Thtml  <./keyrings.7 >/dev/null
> > free(): double free detected in tcache 2
> > Aborted
> > alx@debian:~/tmp/groff$ troff --version
> > GNU troff (groff) version 1.23.0.1234-a0890
> 
> Hummm, it looks like a regression in the master branch.  I can't
> reproduce it in groff-1.23.0.

Me neither.

I bisected it down to this.

0951ff53e47cfc8dda792e23f2111268bd3dd81b is the first bad commit
commit 0951ff53e47cfc8dda792e23f2111268bd3dd81b
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Aug 10 02:08:17 2023 -0500

    [man]: Fix Savannah #64539 (add `TS` register).

    [man]: Add new `TS` register to configure required separation between a
    (`IP`, `TP`) paragraph's tag and its body, and change the default amount
    used for this purpose from 1n ro 2n.  Retire private register
    `an-tag-separation` in favor of `TS`.

    * tmac/an.tmac: Assign `TS` value of 2n if not already defined.

      (TH): Stop setting the default here.

      (an-write-paragraph-tag): Use it.

    Fixes <https://savannah.gnu.org/bugs/?64539>.  Thanks to Alex Colomar
    for the report.

 ChangeLog    | 14 ++++++++++++++
 tmac/an.tmac |  7 +++++--
 2 files changed, 19 insertions(+), 2 deletions(-)

Until grohtml's putatively sloppy handling of memory can be sorted out,
let this be an object lesson in being careful what you wish for.  ;-)

Regards,
Branden

signature.asc
Description: PGP signature