Re: [PATCH] mmap support and x86_64 detection

[Yoshinori K. Okuji]

On Monday 15 August 2005 00:27, Ruslan Nikolaev wrote:
> Yesterday I sent patch for mmap support and x86_64 detection. What do you
> think about? I need to known about it becuase I'll be busy this week...

The detection code should not be a part of the kernel. You can do this only 
protected mode, right? I prefer implementing this with inline assembly.

BTW, I think the current implementation of the multiboot loader is quite 
buggy. It loads an OS image only if it fits into between GRUB_OS_AREA_ADDR 
and GRUB_OS_AREA_ADDR + GRUB_OS_AREA_SIZE. Clearly, this is a bad assumption, 
since GRUB should not force its own internal structure. Instead, GRUB should 
always load an OS image onto the OS area, and relocates it before booting. 
Also, the command line buffer should not be in the heap, because this can be 
overridden when relocating an OS image. Instead, GRUB should move the 
Multiboot Information and related memory regions to somewhere safer (e.g. 
0x2000-0x7000).

Okuji