Re: [patch] rough Mac OS X loader

[Hollis Blanchard]

On Jan 2, 2006, at 12:02 PM, Marco Gerards wrote:

> Hollis Blanchard <address@hidden> writes:
>
> > > > +void EXPORT_FUNC (grub_jump) (unsigned long text, unsigned long
> > > > stack,
> > > > +                             unsigned long arg1, unsigned long arg2);
> > >
> > > Shouldn't a pointer be used here?
> >
> > Used where?
>
> For grub_jump's arguments.  It jumps to some address, right?

Yes, but I don't believe using pointers would be appropriate here. The 
addresses passed in are addresses, so would need to be cast into 
pointers.

Here is the updated patch. I believe I've resolved all your other 
comments.

-Hollis

macosx.txt
Description: Text document