[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: New patch for video subsystem...
From: |
Marco Gerards |
Subject: |
Re: New patch for video subsystem... |
Date: |
Sun, 12 Mar 2006 15:50:55 +0100 |
User-agent: |
Gnus/5.1007 (Gnus v5.10.7) Emacs/21.4 (gnu/linux) |
Vesa Jääskeläinen <address@hidden> writes:
> Marco Gerards wrote:
>> Vesa Jääskeläinen <address@hidden> writes:
>>
>> Hi Vesa,
>>
>> Thanks for your patch. I have done a review, but you should know that
>> I am not a graphics expert and don't understand all of the code in
>> detail. Most issues are GCS related, they don't only apply to the
>> line I commented on, but in general. Please make sure all the code is
>> fixed and not this single line.
>
> That wasn't a small job ;).. I hope I got all right.
One more thing... Can you check if the endianess when loading fonts is
converted to the machine endianess? I had some serious doubts that
this was done correctly. This should work, otherwise your code will
seriously break on some archs...
--
Marco