Re: [PATCH] Fix for configure on x86_64 (Was: Re: [patch] Fix for building correct code on i386-pc (CVS-HEAD))

[Yoshinori K. Okuji]

On Wednesday 31 May 2006 23:00, Jeroen Dekkers wrote:
> It's actually a necessary feature for GRUB on amd64. On amd64 you have
> 64-bit executables but GRUB will run in 32-bit mode.
>
> When trying to compile on amd64 I already ran into some problems
> related to that. First of all on amd64 all binaries are run in 64-bit
> mode, so the host CFLAGS variable shouldn't have -m32. Secondly LIBS
> is for the host only and shouldn't be defined when running target
> tests. As last we set CFLAGS, CC, etc. to the TARGET_*, then we run
> some checks and change the TARGET_* flags without updating CC, CFLAGS,
> etc to the new version.
>
> The attached patch should fix those problems. I've tested it on i386-pc
> and x86_64.

It looks good. Please check it in.

Thanks,
Okuji