Re: GRUB_IEEE1275_FLAG_NO_PARTITION_0

[Hollis Blanchard]

On Mon, 2007-07-09 at 17:05 +0200, Robert Millan wrote:
> What's the point of GRUB_IEEE1275_FLAG_NO_PARTITION_0 ?  We have code that
> checks this flag, but nobody initialises it:
> 
>   disk/ieee1275/ofdisk.c:  if (! grub_ieee1275_test_flag 
> (GRUB_IEEE1275_FLAG_NO_PARTITION_0))
>   include/grub/ieee1275/ieee1275.h:  GRUB_IEEE1275_FLAG_NO_PARTITION_0,

In IEEE1275, partition 0 (as in "disk:0") means "the whole disk".
However, CodeGen-based firmware (that means Genesi) have a bug where
partition 0 is actually disk partition 1. In that case, to access the
whole disk, GRUB must open "disk" instead of "disk:0".

I have no idea how the initialization got lost; it should be initialized
in the same place that the other flags are. Checking cvs history may be
in order.

-Hollis