[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Move os dependent code to a separate file ?
|
From: |
Robert Millan |
|
Subject: |
Re: Move os dependent code to a separate file ? |
|
Date: |
Sat, 2 Feb 2008 17:43:26 +0100 |
|
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Sat, Feb 02, 2008 at 10:29:20PM +0800, Bean wrote:
> Hi,
>
> i can see that there are linux specific code in util/biosdisk.c,
> perhaps we should move them to a separate file such as util/osdep.c ?
In general I don't like very much to split unportable code in separate files
because it's easy to lose context of what it is doing. But some Linux-specific
code in that file is obsolete, IIRC, inherited from GRUB Legacy just to support
ancient libcs. Maybe part of it needs to be considered for removal.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)