Re: grub.cfg parser still doesn't abort on error

[Robert Millan]

On Sun, Feb 03, 2008 at 11:05:26AM +0800, Bean wrote:
> > > > Try the following grub.cfg:
> > > >
> > > >   cat (memdisk)/non-existant-file
> > > >   echo this point should never be reached
> > > >   read
> > > >
> > > > You'll see that the echo is reached, even if cat returned an error.
> > > >
> > > > This becomes much worse when found in situations like:
> > > >
> > > >   font (xxx)/some-file.pff
> > > >   terminal gfxterm
> > > >
> > > > and the font wasn't loaded.
> > >
> > > Urgh!  Bean committed a patch that zero'ed the error.  Perhaps it was
> > > wrong? ;-)
> > >
> > > Can you try reverting it? :-)
> >
> > Actually, it was wrong before that.
> 
> i think you can use the if statement to test command result.

You mean it is intentional?  I think it's a bad plan to assume user will check
for error status of each command, specially in situations like font/gfxterm.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)