|
From: | Vesa Jääskeläinen |
Subject: | Re: [PATCH] a.out support for multiboot and freebsd |
Date: | Sun, 10 Feb 2008 11:22:38 +0200 |
User-agent: | Thunderbird 2.0.0.9 (Windows/20071031) |
Bean wrote:
On Feb 10, 2008 5:57 AM, walt <address@hidden> wrote:Bean wrote:Hi, This patch add a.out support for multiboot. It also support the boot2 loader (a.out format) of freebsd: set root=(hd0,0,a) aout_freebsd /boot/loader boot 2008-02-10 Bean<address@hidden> ...Hi Bean, and thanks for the patch. Unfortunately, the patch is malformed in at least two places and also has whitespace corruption. I did my best to edit the patch by hand until it seemed to apply okay, but I don't trust my results. I have this same patch corruption problem with many of your posts. Can you change the way you attach patches somehow? Maybe change email client? Anyone else have a suggestion? Bean, can you download your own patch from the mailing list and see if it will apply to your own code?i'm using the web interface to send patch, maybe it cause some problem. here is the raw diff file, it should be fine.
Hi,I looked differences of your patch attachments as compared with others that seems to be working nicely. When you copy'n'paste they will get broken.
Here is example from my message (mail client was Thunderbird): Content-Type: text/plain; name="unknown_glyph.diff" Content-Disposition: inline; filename="unknown_glyph.diff" Content-Transfer-Encoding: Base64 And here is example from your email: Content-Type: application/octet-stream; name=a3.diff Content-Transfer-Encoding: base64 X-Attachment-Id: f_fch5ujm00 Content-Disposition: attachment; filename=a3.diffWith a quick check, gmail indeed does send them as binary as default when using Opera. Then I configured Opera to understand diff files (eg. that they are "text/plain"), after that gmail sent patches nicely. Perhaps you could add new MIME type to your web browser to handle "diff" file extesions as "text/plain"?
Thanks, Vesa Jääskeläinen
[Prev in Thread] | Current Thread | [Next in Thread] |