[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Infinite loop regression due to recent change in hostfs.c
From: |
Christian Franke |
Subject: |
Infinite loop regression due to recent change in hostfs.c |
Date: |
Sat, 05 Apr 2008 13:36:29 +0200 |
User-agent: |
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1.11) Gecko/20071128 SeaMonkey/1.1.7 |
Pavel Roskin wrote:
...
Log message:
2008-03-30 Pavel Roskin <...>
* disk/host.c: Include grub/misc.h to fix a warning.
* util/hostfs.c: Use GRUB_MOD_INIT and GRUB_MOD_FINI to fix
warnings about implicit declarations.
CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/grub2/ChangeLog?cvsroot=grub&r1=1.618&r2=1.619
http://cvs.savannah.gnu.org/viewcvs/grub2/disk/host.c?cvsroot=grub&r1=1.2&r2=1.3
http://cvs.savannah.gnu.org/viewcvs/grub2/util/hostfs.c?cvsroot=grub&r1=1.4&r2=1.5
The change in hostfs.c introduces an interesting regression: hostfs now appears
in *_init.lst and grub_hostfs_init() is called twice in grub-emu and
grub-fstest. This results in a infinite loop because the hostfs entry of
grub_fs_list points to itself.
Demo version :-)
$ grub-fstest -d all /dev/sdX ls -l | grep Detecting | head -10000 | uniq -c
You should either undo this change or remove extra calls to
grub_hostfs_init/fini from grub-emu.c and grub-fstest.c. The latter might not
work if it is necessary to init hostfs first for some reason.
Christian
- Infinite loop regression due to recent change in hostfs.c,
Christian Franke <=