Re: [PATCH] Fix prefix problem with LVM on RAID

[Robert Millan]

On Sun, Apr 13, 2008 at 06:07:22PM +0200, Guntsche Michael wrote:
> 
> On Apr 13, 2008, at 17:04, Robert Millan wrote:
> >On Sat, Feb 23, 2008 at 09:54:35PM +0100, Michael Guntsche wrote:
> >>Hello,
> >>
> >>While testing a soon to be deployed setup here I noticed that grub-
> >>setup is setting the prefix wrong if you run
> >>LVM on Software RAID
> >>
> >>grub-setup -v /dev/md0
> >>...
> >>grub-setup: info: dos partition is -2, bsd partition is -2, prefix is
> >>(md0)(fatoftheland-main)/boot/grub
> >>...
> >>
> >>As you can see the there is also (md0) in the prefix which does not
> >>work.
> >>Attached a small patch that fixes this problem for me. I am not sure
> >>if it is the best way to fix it so please take a look.
> >>If the root device is on LVM only add the LVM part if it is on RAID
> >>only add the RAID part.
> >
> >Sorry for the delay in repliing.  I think it's more correct this  
> >way.  Does
> >it work for you?
> 
> Hello Robert,
> 
> Take a look at the for loop later on in the MD case, that is not being  
> called with your patch.
> The code gets all RAID disks and calls setup on each of them. I do not  
> think the setup call further down is doing the same thing, haven't  
> checked it though. With my patch "setup" is still called for each RAID  
> member with the correct prefix. In the case of a faulty disk you can  
> still boot from the degraded array, by choosing a different disk.

Ok, second try.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)

raid.diff
Description: Text Data