Re: [PATCH] Preserve build IDs

[Robert Millan]

On Tue, Apr 15, 2008 at 12:41:50AM +0200, Lubomir Kundrak wrote:
> This will make Fedora packagers have good sleep. I think we discussed
> this already on the list. Rationale behind disabling build-ids
> completely was that it caused images to grow a lot. Correct solution is
> to disable it from images only and let it exists in elf files for
> debugging purposes.
> 
> 2008-04-15  Lubomir Kundrak  <address@hidden>
> 
>       * aclocal.m4 (grub_PROG_OBJCOPY_ABSOLUTE): take only .text
>       section into account, newer toolchains generate unique build ids
>       * configure.ac: remove the test for --build-id=none acceptance,
>       we want build ids to bre preserved
>       * genmk.rb: add -R .note.gnu.build-id to objcopy, so build id
>       far from other sections don't cause the raw binary images grow
>       size

Looks good to me.  Pavel will probably know better though.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)