Re: [PATCH] Make gdb debugging a bit less painful

[Robert Millan]

On Fri, Apr 18, 2008 at 11:16:43AM -0400, Pavel Roskin wrote:
> 
> On Fri, 2008-04-18 at 14:13 +0200, Robert Millan wrote:
> > On Fri, Apr 18, 2008 at 01:32:59PM +0200, Robert Millan wrote:
> > > - jmp EXT_C(cmain)
> > > + jmp EXT_C(grub_main)
> > 
> > Or maybe that should be a "call" instead..
> 
> Only if there is any chance of return, and we can handle it.

Well, Lubomir suggested that you need that return address for gdb.  Is that
correct?

> "exit" in open firmware based systems would probably mean returning
> control to open firmware.

Note that our ieee1275 exit is implemented via interrupt, which I believe
has equivalent effect.  We don't need the return address for that, in this
case.

> By the way, it would be nice to have "exit" in both grub for PC and
> grub-emu, and not only in the rescue mode.  "exit" on PC means returning
> control to BIOS so it can try another boot device.  "exit" in grub-emu
> means exit, of course.  I have to use "reboot" now (which should not
> exit, but rather restart grub-emu, if it belongs to grub-emu at all) or
> "rescue" followed by "exit".

Agreed.

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call… if you are unable to speak?
(as seen on /.)