RE: [PATCH] GRUB2 does not provide Multiboot Legacy memory map

[Julian Salazar]

Attached is the patch. Since I'm not completely familiar with GRUB2's
internals, there might be a more efficient way of implementing this.

Thoughts/improvements?

> -----Original Message-----
> From: address@hidden [mailto:grub-
> address@hidden On Behalf Of Thomas Schwinge
> Sent: April-19-08 3:32 PM
> To: Julian Salazar
> Cc: address@hidden
> Subject: Re: [PATCH] GRUB2 does not provide Multiboot Legacy memory map
> 
> Hello!
> 
> On Sat, Apr 19, 2008 at 03:11:43PM -0600, Julian Salazar wrote:
> > I'm developing a small kernel and I've been using GRUB2 with the Legacy
> > Multiboot Specification for some time now. I've noticed that it does not
> > provide some of the things in the Multiboot Information structure that
> GRUB
> > Legacy does, like the memory map. So I've created a small patch which
> works
> > in QEMU and real hardware so that GRUB2 will pass the memory map to my
> > kernel or any multiboot-compliant kernel for the i386-pc.
> 
> Now this is interesting as I've just today seen an incompatibility
> between booting a multiboot kernel with GRUB legacy and GRUB2.  It might
> actually be the same issue, but I didn't fully investigate yet.
> Therefore I'm quite interested in seeing your patch.
> 
> 
> > Since I've never actually contributed code to a GNU project before, are
> 
> Welcome!
> 
> > there certain rules and regulations of some sort that I have to comply
> with
> 
> Your guessed right: sure there are :-).  See, for example, (parts of) the
> GNU Coding Standards, <http://www.gnu.org/prep/standards/html_node/>.
> Not everything is relevant in your case, though.
> 
> > before I can send my patch here?
> 
> Feel free to simply send it here and we'll tell you what needs to be
> changed.
> 
> 
> Regards,
>  Thomas

multiboot_memmap.patch
Description: Binary data