[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arbitrary drive names in device.map
From: |
Robert Millan |
Subject: |
Re: [PATCH] arbitrary drive names in device.map |
Date: |
Fri, 30 May 2008 12:50:19 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Thu, May 29, 2008 at 07:12:52PM -0400, Pavel Roskin wrote:
> On Wed, 2008-05-28 at 23:36 +0200, Robert Millan wrote:
> > Hi,
> >
> > This patch fixed the device.map handlers to accept any device name for grub
> > drives, rather than just BIOS-style "hd[0-9]" and "fd[0-9]". It makes
> > update-grub usable on OFW, Coreboot, etc.
> >
> > Any comments?
>
> That's a very welcome change!
Ok. Committed.
> By the way, biosdisk.c becomes a misnomer. If I understand correctly,
> biosdisk.c is not going to be emulating anything BIOS specific with your
> patch.
How about renaming to util/disk.c ?
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)