[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: backwards compatibility in grub.cfg
From: |
Robert Millan |
Subject: |
Re: backwards compatibility in grub.cfg |
Date: |
Sat, 31 May 2008 11:47:23 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Fri, May 30, 2008 at 11:47:18PM +0200, Christian Franke wrote:
> Robert Millan wrote:
>
> >diff -x configure -x config.h.in -x CVS -x '*~' -x '*.mk' -urp
> >../grub2/util/update-grub_lib.in ./util/update-grub_lib.in
> >--- ../grub2/util/update-grub_lib.in 2008-05-30 22:55:35.000000000 +0200
> >+++ ./util/update-grub_lib.in 2008-05-30 23:16:53.000000000 +0200
> >@@ -116,10 +116,9 @@ prepare_grub_to_access_device ()
> >
> > # If there's a filesystem UUID that GRUB is capable of identifiing, use
> > it;
> > # otherwise set root as per value in device.map.
> >+ echo "set root=`${grub_probe} --device ${device} --target=drive`"
> > if fs_uuid="`grub-probe --device ${device} --target=fs_uuid 2>
> > /dev/null`" ; then
> >
>
> Outside of the scope of the patch, but shouldn't '${grub_probe}' be used
> instead of 'grub-probe' in the rest of the script?
>
> Same issue is in update-grub.in: grub_probe is set but never used, so
> update-grub fails if /usr/sbin is not in PATH.
Fixed.
--
Robert Millan
<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)