Re: [PATCH] Patch for the open hackware

[Bean]

On Wed, Jun 18, 2008 at 1:45 AM, Bean <address@hidden> wrote:
> On Wed, Jun 18, 2008 at 1:39 AM, Robert Millan <address@hidden> wrote:
>> On Tue, Jun 17, 2008 at 11:44:36PM +0800, Bean wrote:
>>> +  if (grub_ieee1275_test_flag (GRUB_IEEE1275_FLAG_CANNOT_INTERPRET))
>>> +    {
>>> +      grub_addr_t addr;
>>> +      grub_uint32_t len;
>>> +
>>> +      addr = HEAP_MAX_ADDR - HEAP_MIN_SIZE;
>>> +      len = HEAP_MIN_SIZE;
>>> +
>>> +      if (grub_claimmap (addr, len) < 0)
>>> +        return grub_error (GRUB_ERR_OUT_OF_MEMORY,
>>> +                           "Failed to claim heap at 0x%llx, len 0x%llx\n",
>>> +                           addr, len);
>>> +
>>> +      grub_mm_init_region ((void *) addr, len);
>>> +    }
>>> +  else
>>> +    grub_available_iterate (heap_init);
>>>  }
>>
>> This skips all the checks in heap_init(), which were intended for situations
>> that could also apply to Open Hackware.  Would be better if you call
>> heap_init() with the desired parameters instead.
>
> Hi,
>
> You're right, this is the new patch.
>
> btw, I also include the previous elf header patch. It's working in
> linuxbios, olpc and ppc, I guess it should be all right.

Hi,

If no one objects, I'd like to commit this soon.

-- 
Bean