Re: Endianness macros capitalization

[Pavel Roskin]

On Sat, 2008-07-05 at 15:27 +0200, Javier Martín wrote:
> Just my two (euro) cents: why are the endianness macros written like
> functions? I'm talking about the grub_Xe_to_cpuNN family, which look
> like function calls instead of the macros they are. Shouldn't they be
> capitalized to GRUB_LE_TO_CPU32 and such?

They probably should be functions.  We may want to sparse annotate GRUB
one day, and then inline functions in the only way to go.

I prefer capitalized names only for macros that cannot be functions or
have non-trivial size effects.

-- 
Regards,
Pavel Roskin