Re: [PATCH] New x86_64 EFI patch

[Bean]

On Thu, Jul 17, 2008 at 11:45 PM, Javier Martín <address@hidden> wrote:
> El jue, 17-07-2008 a las 23:26 +0800, Bean escribió:
>> On Thu, Jul 17, 2008 at 11:22 PM, Pavel Roskin <address@hidden> wrote:
>> > On Thu, 2008-07-17 at 17:02 +0200, Javier Martín wrote:
>> >> El jue, 17-07-2008 a las 17:50 +0800, Bean escribió:
>> >> > Committed.
>> >> >
>> >> Seemingly, the fact that there is now separate recognition for "x86_64"
>> >> machine types has borked the current build system in amd64 PCs:
>> >>
>> >> $ make
>> >> ./config.status --recheck
>> >> running CONFIG_SHELL=/bin/bash /bin/bash ../src/configure
>> >> --prefix=/home/javier/Proyectos/grub/build/out/  --no-create
>> >> --no-recursion
>> >> checking build system type... x86_64-unknown-linux-gnu
>> >> checking host system type... x86_64-unknown-linux-gnu
>> >> checking target system type... x86_64-unknown-linux-gnu
>> >> configure: error: unsupported machine type
>> >> make: *** [config.status] Error 1
>> >
>> > I've just noticed that.  I think x86_64 should default to "i386-pc"
>> > platform.  I'll have a look how to do it nicely.
>>
>> I have the following in configure.ac:
>>
>> if test "x$platform" = "xefi" ; then
>>   case "$target_cpu" in
>>     i386) ;;
>>     x86_64) target_m64=1 ;;
>>     *) AC_MSG_ERROR([unsupported CPU type for EFI]) ;;
>>   esac
>> else
>>   case "$target_cpu" in
>>     i386) ;;
>>     x86_64) target_cpu=i386 target_m32=1 ;;
>>     powerpc) ;;
>>     powerpc64) target_cpu=powerpc target_m32=1;;
>>     sparc64) ;;
>>     *) AC_MSG_ERROR([unsupported CPU type]) ;;
>>   esac
>> fi
>>
>> If platform is not efi, x86_64 will become i386, perhaps there is
>> something I miss ?
>>
>
> It does not reach that point, the "unsupported machine type" message is
> thrown by this earlier check (line 59)

Hi,

Oh, you're right, use this patch:

diff --git a/configure.ac b/configure.ac
index 943b9fe..45eb472 100644
--- a/configure.ac
+++ b/configure.ac
@@ -61,6 +61,7 @@ if test "x$with_platform" = x; then
   case "$target_cpu"-"$target_vendor" in
     i386-apple) platform=efi ;;
     i386-*) platform=pc ;;
+    x86_64-*) platform=pc ;;
     powerpc-*) platform=ieee1275 ;;
     sparc64-*) platform=ieee1275 ;;
     *) AC_MSG_ERROR([unsupported machine type]) ;;


-- 
Bean