Re: Found two disks with the same number 0?!?

[Robert Millan]

On Sat, Jul 12, 2008 at 05:28:00PM +0200, Robert Millan wrote:
> 
> Any comments on this?  I'm inclined to remove the check (or disable it, or
> turn it into a warning), but I'd like to hear what everyone else thinks
> first.

I just turned it into a grub_dprintf() warning.

> On Sat, Jul 05, 2008 at 12:32:05PM +0000, Sam Morris wrote:
> > On my raid1-using system, I get the following error at boot:
> > 
> >   error: Found two disks with the number 0?!?
> > 
> > Robert Millan suggested I apply a patch to print out the two disks with 
> > this problem; they are (hd1,2) and (hd3,2).
> > 
> > If I comment out this check then I can boot normally. Robert things GRUB 
> > is being too conservative here; perhaps this check should be removed?
> > 
> > Index: disk/raid.c
> > ===================================================================
> > --- disk/raid.c     (revision 1691)
> > +++ disk/raid.c     (working copy)
> > @@ -440,18 +440,6 @@
> >  
> >       return 0;
> >     }
> > -  
> > -      if (array->device[sb.this_disk.number] != NULL)
> > -   {
> > -     /* We found multiple devices with the same number. Again,
> > -        this shouldn't happen.*/
> > -
> > -     grub_error (GRUB_ERR_BAD_NUMBER,
> > -                 "Found two disks with the number %d?!?",
> > -                 sb.this_disk.number);
> > -
> > -     return 0;
> > -   }
> >      }
> >  
> >    /* Add an array to the list if we didn't find any.  */
> > 
> > 
> > -- 
> > Sam Morris
> > http://robots.org.uk/
> >  
> > PGP key id 1024D/5EA01078
> > 3412 EA18 1277 354B 991B  C869 B219 7FDB 5EA0 1078
> > 
> > 
> > 
> > _______________________________________________
> > Grub-devel mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/grub-devel
> > 
> 
> -- 
> Robert Millan
> 
> <GPLv2> I know my rights; I want my phone call!
> <DRM> What good is a phone call… if you are unable to speak?
> (as seen on /.)
> 
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
> 

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What good is a phone call… if you are unable to speak?
(as seen on /.)