[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: TSC on coreboot (Re: [PATCH] High resolution time/TSC patch v3)
From: |
Robert Millan |
Subject: |
Re: TSC on coreboot (Re: [PATCH] High resolution time/TSC patch v3) |
Date: |
Mon, 4 Aug 2008 11:09:59 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Sun, Aug 03, 2008 at 07:14:29PM -0700, Colin D Bennett wrote:
> >
> > Note: AFAICT we can't calculate the epoch without RTC. But then
> > again, this epoch is just as defined by the time BIOS enables RTC
> > interrupts, so why not define it ourselves? I propose that we define
> > epoch as the time in which our TSC code is initialized.
> >
> > If knowing the time in which BIOS was started is really useful, maybe
> > we could #ifdef it instead. Though if it's not I'd prefer the
> > simplicity.
>
> So far we never use the value returned by ``grub_get_time_ms()`` as an
> absolute time. It is currently only used in relative terms, so only
> the rate at which it changes is important, not the definition of the
> zero point. Perhaps that simplifies things? I think it's fine to go
> with that definition for now -- if we need to use absolute time at some
> point, we can deal with it then.
Hi Colin,
As far as I'm concerned the combined patch can be committed, even without
the cpuid harmonization I suggested (we can always arrange that later).
If there's no objection I'll check it in.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."