Re: [PATCH] PXE support for grub2

[Bean]

On Tue, Aug 5, 2008 at 4:16 PM, Marco Gerards <address@hidden> wrote:
> Bean <address@hidden> writes:
>
>>>> +GRUB_MOD_INIT(pxe)
>>>> +{
>>>> +  (void) mod;                        /* To stop warning. */
>>>> +
>>>> +  grub_pxe_detect ();
>>>> +  if (grub_pxe_pxenv)
>>>> +    {
>>>> +      grub_disk_dev_register (&grub_pxe_dev);
>>>> +      grub_fs_register (&grub_pxefs_fs);
>>>
>>> filesystems belong in fs/
>>
>> Perhaps I should place it in fs/i386/pc ?
>
> I think it would make things clearer, although I am not too sure :-)
>
>>>> +struct grub_pxenv
>>>> +{
>>>> +  grub_uint8_t signature[6]; /* 'PXENV+' */
>>>> +  grub_uint16_t version;     /* MSB = major, LSB = minor */
>>>> +  grub_uint8_t length;               /* structure length */
>>>> +  grub_uint8_t checksum;     /* checksum pad */
>>>> +  grub_uint32_t rm_entry;    /* SEG:OFF to PXE entry point */
>>>> +  grub_uint32_t      pm_offset;      /* Protected mode entry */
>>>> +  grub_uint16_t pm_selector; /* Protected mode selector */
>>>> +  grub_uint16_t stack_seg;   /* Stack segment address */
>>>> +  grub_uint16_t      stack_size;     /* Stack segment size (bytes) */
>>>> +  grub_uint16_t bc_code_seg; /* BC Code segment address */
>>>> +  grub_uint16_t      bc_code_size;   /* BC Code segment size (bytes) */
>>>> +  grub_uint16_t      bc_data_seg;    /* BC Data segment address */
>>>> +  grub_uint16_t      bc_data_size;   /* BC Data segment size (bytes) */
>>>> +  grub_uint16_t      undi_data_seg;  /* UNDI Data segment address */
>>>> +  grub_uint16_t      undi_data_size; /* UNDI Data segment size (bytes) */
>>>> +  grub_uint16_t      undi_code_seg;  /* UNDI Code segment address */
>>>> +  grub_uint16_t      undi_code_size; /* UNDI Code segment size (bytes) */
>>>> +  grub_uint32_t pxe_ptr;     /* SEG:OFF to !PXE struct */
>>>> +} __attribute__ ((packed));
>>>
>>> Can you GRUB-ify the comments here and below a bit?
>>
>> What do you mean by "GRUB-ify the comments" ?
>
> ".  */
>
> Although it is not too important for structs, I think :-)

Fixed and committed.

-- 
Bean