[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] just skip over invalid/unsupported RAID
From: |
Robert Millan |
Subject: |
Re: [PATCH] just skip over invalid/unsupported RAID |
Date: |
Mon, 11 Aug 2008 16:28:57 +0200 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Mon, Aug 11, 2008 at 01:42:16PM +0200, Felix Zielcke wrote:
> GRUB shouldn't fail to rescue mode, if an unsupport RAID (in this case
> 6) is used on disks which GRUB doestn't even need to access.
I think the right solution for this would be to handle the errors in the
upper layer instead of removing them.
In this case, grub_raid_scan_device() is called from GRUB_MOD_INIT(raid),
which doesn't handle them, and then when they're handled the only option
is to abort normal mode.
GRUB_MOD_INIT(raid) could handle them just fine, with something like:
grub_print_error ();
grub_errno = GRUB_ERR_NONE;
if an error was found.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."