Re: [PATCH] Home-End keys in menu

[Carles Pina i Estany]

Hello,

I reply in this message a different things.

On Aug/13/2008, Robert Millan wrote:
> On Wed, Aug 13, 2008 at 01:38:27PM +0200, Javier Martín wrote:
> > El mié, 13-08-2008 a las 12:50 +0200, Robert Millan escribió:
> > > On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote:
> > > > Hi,
> > > > 
> > > > Carles Pina i Estany <address@hidden> writes:
> > > > 
> > > > [...]
> > > > 
> > > > > 2008-08-06  Carles Pina i Estany  <address@hidden>
> > > > >
> > > > >       * menu/normal.c (run_menu): Add Home and End keys in grub-menu.
> > > > 
> > > > 
> > > > This looks fine to me at first sight.  Do others have problems with
> > > > this?  Otherwise it can be committed.
> > > 
> > > Why don't we use PgUp / PgDn instead?  That's more intuitive.

I think that we should use Home/End and PgUp/PgDn for different things:

-Home/End: go straight to the first and last entry (this is done)

-PgUp/PgDn: it moves one page (I mean, selected item = selected item +
number of items)

I've implemented only Home/End key (by the moment, we can talk about
PgUp/PgDn later please :-) )

> > Users with long menu lists may expect PgUp/PgDn to take them exactly
> > _one_ page up or down, not the whole list... I personally think that
> > Home/End are more intuitive for this particular UI interaction.
> 
> Uhm you're right.  Also, I notice this behaviour is consistent with
> `less' (and since I love consistency, I must agree with you!)
> 
> I think the patch is fine in its current state.

me too ;-)

-- 
Carles Pina i Estany            GPG id: 0x17756391
        http://pinux.info