Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

[Felix Zielcke]

Am Donnerstag, den 14.08.2008, 20:03 +0200 schrieb Robert Millan:
> 
> Please explain the actual changes (or what they're for).
As I wrote that, I just saw before that Marco did just Rewritten. in a
commit, but with searching for Rewritten in the ChangeLog reveals much
more verbose entrys

So:

2008-08-14  Felix Zielcke  <address@hidden>

        * util/getroot.c: Include <config.h>.
        (grub_util_get_grub_dev): Rewritten to use asprintf for mdraid devices, 
added
        support for /dev/md/N devices and handles LVM double dash escaping.

> 
> >    switch (grub_util_get_dev_abstraction (os_dev))
> >      {
> > -    case GRUB_DEV_ABSTRACTION_LVM:
> > -      grub_dev = xmalloc (strlen (os_dev) - 12 + 1);
> > +      case GRUB_DEV_ABSTRACTION_LVM:
> 
> Try to ommit big indentation changes from the patch.  If you change something
> that requires a big chunk of code to be reindented, I think it's better if you
> leave that out for readability (and mention so if you like).

Unfortunately I couldn't get the -w option working to ignore white space
changes
svn diff --diff-cmd diff -x -up -x -w doestn't produce an unified diff,
< and > are used instead of - and +
with -x -w -x up the -w is ignored :(

So I just need to remember this now that I either change the indention,
before commiting or I directly make 2 patches.
Luckly I can commit this now myself so I really don't need to include
this in the patches I send :)