Re: [PATCH] new static const char[] modname

[Robert Millan]

On Thu, Aug 28, 2008 at 07:09:37PM +0200, Felix Zielcke wrote:
> @@ -248,7 +250,7 @@ grub_scsi_open (const char *name, grub_d
>      {
>        if (! p->open (name, scsi))
>       {
> -       disk->id = (unsigned long) "scsi"; /* XXX */
> +       disk->id = (unsigned long) modname; /* XXX */

I think the idea with this was to unify the strings for grub_dprintf calls;
your patch goes a bit further and also puts other sort of strings to share
the same variable.

I think that's a bit dangerous, since changes intended for one use of the
variable could collaterally affect the rest in subtle ways.  And it's not
that useful in code size anyway.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."