Re: [PATCH] iso9660 UUID support by using the creation date/time

[Felix Zielcke]

Hello list,

Am Sonntag, den 31.08.2008, 15:47 +0200 schrieb Robert Millan:

> Nice work :-)

By the way the TAB key on emacs is really nice you even don't need to
care about moving the cursor to the beginning of the line :)

> > The specs say that it's allowed to contain only zeros but I think this
> > shouldn't be a big problem.
> 
> I think this could indeed be a problem if it leads to collisions.  If "all
> zeroes" is detected, one could rise an error in uuid() function to prevent the
> caller from taking the value into consideration.

I have now used grub_error (GRUB_ERR_BAD_NUMBER)

But maybe it would be better to make a new type for this, though I don't
have yet an idea how to call it.
Suggestions please :)


> Since the string contains human-readable information, may I suggest separating
> it with dashes to make it easier to comprehend?

Good idea, I should have done that first that would make it even for me a bit 
easier.
I did it now even more human-readable for the `sizeof ()' 

-- 
Felix Zielcke

iso9660_uuid.patch.3
Description: Text document