Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name

[Felix Zielcke]

Commited in the hope that Marco isn't angry with me ;)

and I noticed I used still past once and there was a reason for len = +1
and if < len not <= len

Am Dienstag, den 02.09.2008, 17:59 +0200 schrieb Felix Zielcke:
> Am Dienstag, den 02.09.2008, 17:59 +0300 schrieb Vesa Jääskeläinen: 
> > Felix Zielcke wrote:
> > 
> > sizeof returns type of size_t so it would be good that char k uses that.
> > I am a bit surprised that this didn't generate compiler warning?
> 
> Well somewhere hidden in a mail from me, I think I already wrote that I
> already got the idea to make these warnings more visible :)
> I didn't look yet further into it, maybe even a [RFC] topic should be
> made for this.
> I'm thinking about how linux kernel compiling works.
> 
> Actually I haven't checked that code ;)
> 
> > And there is no reason to define integers as constants unless you really
> > want to make sure they don't change :)
> 
> This is just a thing left from my previous coding experience.
> As I started to code I personally just prefer that, but yeah gcc is so
> nice and optimizes (almost) everything for us and this code is so little
> anyway :)
> 
> > > +   p = strchr (os_dev, 'p');
> > > +   if (p)
> > > +     *p = ',';
> > 
> > It is usually a bad idea to modify source string.
> 
> Urm right this is util/ no need to save a few bytes :)
> 
> Thanks for your suggestions Vesa.
> It really looks now better compared to the first code I sent about this
> problem and it only uses now 3 variables :)
> 
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> http://lists.gnu.org/mailman/listinfo/grub-devel
-- 
Felix Zielcke