Re: [1870] 2008-09-22 Bean -- Missing function call?

[Bean]

On Sun, Sep 28, 2008 at 6:15 AM, Christian Franke
<address@hidden> wrote:
> Bean wrote:
>>
>> Revision: 1870
>>          http://svn.sv.gnu.org/viewvc/?view=rev&root=grub&revision=1870
>> Author:   bean
>> Date:     2008-09-22 04:18:57 +0000 (Mon, 22 Sep 2008)
>>
>> Log Message:
>> -----------
>> 2008-09-22  Bean  <address@hidden>
>>
>>        * fs/ntfs.c (grub_ntfs_iterate_dir): Fix a rare case where $BITMAP
>> is
>>        resident and in attribute list.
>>
>>        * include/grub/ntfs.h (BMP_LEN): Removed.
>>
>> [...}
>> -         if (read_data (at, cur_pos, bmp, 0, u32at (cur_pos, 0x28), 0,
>> 0))
>> +          bitmap_len = ((is_resident) ? u32at (cur_pos, 0x10) :
>> +                        (cur_pos, 0x28));
>> +
>>
>
>
> Compiler warning "left-hand operand of comma expression has no effect"
> suggests that a function/macro call is missing:
>
>          bitmap_len = ((is_resident) ? u32at (cur_pos, 0x10) :
> -                        (cur_pos, 0x28));
> +                        u32at (cur_pos, 0x28));

Hi,

Oh right, thanks for the catch. I'm fixing it now.

-- 
Bean