Re: Bug-fix elf.c powerpc ieee1275

[Robert Millan]

On Mon, Sep 29, 2008 at 12:42:36AM +1000, peter cros wrote:
> Hi,
> 
> There is a bug in /kern/elf.c/ (target powerpc, platform ieee1275),
> causing load linux to fail on my powerpc64 g5 and ibook g4 32bit.
> 
> Here is a diff of the fix I found necessary for rev 1878 (bug has existed in
> previous versions).
> 
> It was a one liner -
> 
> diff -pu grubsvn/kern grubtry/kern/elf.c
> ---------------------------------------------
> --- grubsvn/kern/elf.c    2008-09-28 17:27:56.000000000 +1000
> +++ grubtry/kern/elf.c    2008-09-28 23:16:38.000000000 +1000
> @@ -234,7 +234,7 @@ grub_elf32_load (grub_elf_t _elf, grub_e
> 
>      if (load_hook && load_hook (phdr, &load_addr))
>        return 1;
> -    load_addr = phdr->p_paddr;
> +/** pxwdebug - not required -  load_addr = phdr->p_paddr; **/

Hi,

Thanks for pointing this out.  Unless someone understands your change,
we'd need you to explain why this line isn't necessary, and why it was
causing trouble.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."