Re: [PATCH] PCI serial card support

[Robert Millan]

On Sat, Nov 08, 2008 at 06:58:19PM -0700, address@hidden wrote:
> I think this is pretty much what I'm in the middle of doing.  I want to
> put the infrastructure in place so that we can handle an arbitrary PCI
> device but I will only put the actual code in to handle the PCI card that
> I have (the only one I can test).
> 
> What I'm doing is creating a table that matches the tuple (vendor id,
> device id, subsystem vendor id, subsystem device id, device type, device
> type mask) to a base baud and a configuration function.  The default
> configuration function does nothing so the table only provides the base
> baud.  We can add config functions for different cards as time goes by.

Nice!  Aside from base baud and configuration function, I assume we'd also
want to specify the I/O port?

> Note that what I'm doing will make the serial module dependent upon the
> pci module but I don't see that that's a big concern.  Pretty much any
> modern machine will have a PCI bus so scanning it should not be a
> problem.  Also, note that the legacy serial devices (I/O ports at
> 0x3f8 & 0x2f8) are going away, in the not too distant future the only
> way to get serial output will be through PCI or USB.  Given that USB
> controllers hang off the PCI bus I don't see an issue with having the
> serial module require the pci module.

If we want to soften the dependency on the pci module, I guess it can
always be done afterwards.  Vesa, what do you think?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."